🤖 GitHub comments

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@kdelemme I noticed that the Query filter and Partition by are disabled when user lands to the SLO create form from the apm callout.

Is this expected behaviour?

@kdelemme I noticed that the Query filter and Partition by are disabled when user lands to the SLO create form from the apm callout.

Screen.Recording.2023-09-28.at.14.18.41.mov
Is this expected behaviour?

Indeed, It is expected because the Transaction Name is not selected (or provided by the url state from the APM page).

@kdelemme Same happens when the Transaction Name is selected. I'll check how the form validation is done.

I don't have this behaviour... let me investigate further.

@kdelemme In my case index is undefined and that's why query filter and partition by fields are disabled. I'll try again, maybe I do something wrong. But I guess we need to set the index param when we click on the apm call out.

When I create the SLO from the SLO page, index is metrics-apm*, apm-*

Maybe a race condition, I need to take a closer look at this. But does the indicator form works when not coming from a prefilled url?

Yes it works, when not coming from a prefilled url. I can file a separate ticket for this issue with clear steps to reproduce and we fix there. I can have a look.

Here's the ticket #167630. If I hardcode the index here, it works: the query filter and the partition by fields are not disabled. So I just need to figure out how to dynamically get the index name. I am not sure if I want to send an index param from the apm page or set directly the index in the apm_availability_indicator_type_form.tsx if param index is undefined. Most probably the 2nd option. What do you think?

@mgiota Actually if the index is supposed to be automatically filled by the form, if using the url state to prefill the form breaks this, we should not merge this PR. I'm going to investigate further and implement the fix in this PR

@mgiota Good find with the bug! I've fixed it fetching the apm index when the form renders.
I've tested the following scenarios:

1. From the APM page using the URL state
2. From the Create SLO button, selecting APM Availability then APM latency
3. From the Edit SLO button

If you want to see what is contained in the form at any time, I use this in the main slo_edit_form component:

<pre>{JSON.stringify(watch('indicator'), null, 2)}</pre>

💚 Build Succeeded

• Buildkite Build
• Commit: cfae808

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

History

• 💛 Build #163670 was flaky 2d04879
• 💛 Build #162474 was flaky 541a551
• 💔 Build #162394 failed 3f5bd11
• 💔 Build #162345 failed ce855f8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

💔 All backports failed

Manual backport

To create the backport manually run:

node scripts/backport --pr 167247

Questions ?

Please refer to the Backport tool documentation

As soon as this backport is merged, I'll be able to backport this PR into 8.10 as well.

💚 All backports created successfully

Status	Branch	Result
✅	8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation